Fix flaky ScorekeeperSessionTest #11

Merged
devadmin merged 1 commits from fix/scorekeeper-test-flake into dev 2026-10-17 14:01:39 -06:00
Owner

admittedGuest returned once the guest was connected, but the host's sheet arrives separately over the socket, so tests reading the guest's players immediately could see an empty list (IndexOutOfBoundsException in "the host's own change reaches the guests"). The helper now waits for the guest to hold the host's sheet.

Test-only change. 0 failures in 12 consecutive runs, against about 1 in 3 before.

🤖 Generated with Claude Code

https://claude.ai/code/session_016eTor2tpxKb4dXbd8RqnvZ

`admittedGuest` returned once the guest was `connected`, but the host's sheet arrives separately over the socket, so tests reading the guest's players immediately could see an empty list (`IndexOutOfBoundsException` in "the host's own change reaches the guests"). The helper now waits for the guest to hold the host's sheet. Test-only change. 0 failures in 12 consecutive runs, against about 1 in 3 before. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016eTor2tpxKb4dXbd8RqnvZ
devadmin added 1 commit 2026-10-17 13:52:45 -06:00
Fix a race in ScorekeeperSessionTest's admittedGuest helper
CI / Deploy to Cloudflare Pages (pull_request) Skipped
CI / Build and check (pull_request) Successful in 8m32s
a8ff9863a6
A guest counts as connected before the host's sheet has arrived over the socket, so
tests that read the guest's players straight away could see an empty list. The helper
now waits for the guest to hold the host's sheet. 0 failures in 12 runs (was ~1 in 3).

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_016eTor2tpxKb4dXbd8RqnvZ
devadmin merged commit 2e66567643 into dev 2026-10-17 14:01:39 -06:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devadmin/ProLibertateGames#11